Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-vi-mode: remove bottle :unneeded #75944

Closed

Conversation

nandahkrishna
Copy link
Member

See #75943.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@nandahkrishna nandahkrishna added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Apr 26, 2021
@nandahkrishna
Copy link
Member Author

nandahkrishna commented Apr 26, 2021

6bd41a235238ffa0aa1016fa1f47626dac42be943209ceafecc6bdc146c29dde  zsh-vi-mode--0.8.2.arm64_big_sur.bottle.tar.gz
6bd41a235238ffa0aa1016fa1f47626dac42be943209ceafecc6bdc146c29dde  zsh-vi-mode--0.8.2.big_sur.bottle.tar.gz
6bd41a235238ffa0aa1016fa1f47626dac42be943209ceafecc6bdc146c29dde  zsh-vi-mode--0.8.2.catalina.bottle.tar.gz
e71dd512522b81a93fb0e8dfc34c7e4898d542b0582c113e140da2b57ee7f7ff  zsh-vi-mode--0.8.2.mojave.bottle.tar.gz

Diff (don't know if I'm doing this right 😅):

--- zsh-vi-mode--0.8.2.big_sur.bottle.tar
+++ zsh-vi-mode--0.8.2.mojave.bottle.tar
@@ -1,9 +1,9 @@
 drwxr-xr-x   0        0        0        0 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/
 -rw-r--r--   0        0        0     1078 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/LICENSE
 drwxr-xr-x   0        0        0        0 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/.brew/
+-rw-r--r--   0        0        0      777 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/.brew/zsh-vi-mode.rb
 -rw-r--r--   0        0        0    17764 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/README.md
 drwxr-xr-x   0        0        0        0 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/share/
 drwxr-xr-x   0        0        0        0 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/share/zsh-vi-mode/
 -rw-r--r--   0        0        0       32 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/share/zsh-vi-mode/zsh-vi-mode.plugin.zsh
 -rw-r--r--   0        0        0    81477 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/share/zsh-vi-mode/zsh-vi-mode.zsh
--rw-r--r--   0        0        0      777 2021-04-04 15:15:10.000000 zsh-vi-mode/0.8.2/.brew/zsh-vi-mode.rb

@MikeMcQuaid
Copy link
Member

@nandahkrishna Interesting, perhaps we need to sort the input files somehow? @Bo98 any ideas?

@MikeMcQuaid MikeMcQuaid removed their request for review April 26, 2021 16:11
@Bo98
Copy link
Member

Bo98 commented Apr 26, 2021

Wow, that's an interesting one. I think it might actually be sorted by inode number.

I'm not entirely sure if there's a fix for that beyond iterating the directory ourselves. Honestly, some more manual handling like that is beginning to look like the best solution. I'll play around with it a bit.

@Bo98
Copy link
Member

Bo98 commented Apr 26, 2021

gnu-tar does have --sort=name. bsdtar does not.

It was only introduced in GNU tar 1.28, which luckily Ubuntu 16.04 does seem to ship with.

@MikeMcQuaid
Copy link
Member

gnu-tar does have --sort=name.

Would be interested if this alone is enough to fix this.

@nandahkrishna
Copy link
Member Author

4ef061c362f1a957cb1ffb3bbf50763e34d1751ce9e46dca30bfeabc6e3f21ce  zsh-vi-mode--0.8.2.arm64_big_sur.bottle.tar.gz
4ef061c362f1a957cb1ffb3bbf50763e34d1751ce9e46dca30bfeabc6e3f21ce  zsh-vi-mode--0.8.2.big_sur.bottle.tar.gz
4ef061c362f1a957cb1ffb3bbf50763e34d1751ce9e46dca30bfeabc6e3f21ce  zsh-vi-mode--0.8.2.catalina.bottle.tar.gz
4ef061c362f1a957cb1ffb3bbf50763e34d1751ce9e46dca30bfeabc6e3f21ce  zsh-vi-mode--0.8.2.mojave.bottle.tar.gz

@nandahkrishna nandahkrishna added the ready to merge PR can be merged once CI is green label Apr 27, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@nandahkrishna nandahkrishna deleted the bottle-zsh-vi-mode branch April 28, 2021 02:19
@chenrui333 chenrui333 added the bottle-up-everything Make every formula bottled label May 3, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants